Fix(is_feature_enabled): Added rollout experiment key map for onboarding datafile #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # split out the experiment id map for rollouts | ||
| # split out the experiment id and key map for rollouts | ||
| @rollout_experiment_id_map = {} | ||
| @rollout_experiment_key_map = {} |
Contributor
There was a problem hiding this comment.
Now where rollout_experiment_id_map is being used in the code.
| @rollout_experiment_id_map = @rollout_experiment_id_map.merge(generate_key_map(exps, 'id')) | ||
| @rollout_experiment_key_map = @rollout_experiment_key_map.merge(generate_key_map(exps, 'key')) | ||
| end | ||
| @all_experiments = @experiment_key_map.merge(@rollout_experiment_id_map) |
Contributor
There was a problem hiding this comment.
Wow this is a big mistake we didn't catch in the code review last time around
Contributor
There was a problem hiding this comment.
Luckily IDs and keys have been same, but if it had changed things would be really very bad.
aliabbasrizvi
approved these changes
May 17, 2019
| @rollout_experiment_id_map = @rollout_experiment_id_map.merge(generate_key_map(exps, 'id')) | ||
| @rollout_experiment_key_map = @rollout_experiment_key_map.merge(generate_key_map(exps, 'key')) | ||
| end | ||
| @all_experiments = @experiment_key_map.merge(@rollout_experiment_id_map) |
Contributor
There was a problem hiding this comment.
Luckily IDs and keys have been same, but if it had changed things would be really very bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues