Skip to content

chore: Exclude dev dependencies from source clear check #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Dec 11, 2020

Summary

Source clear was also checking for vulnerabilities in dev dependencies. Added a srcclr.yml file with scope:production to ignore checking dev dependencies.

Test Plan

Source clear tests now show zero vulnerabilites.

@zashraf1985 zashraf1985 force-pushed the zeeshan/fix-more-vulnarabilities branch from cfe083e to ee3d7cd Compare December 31, 2020 18:49
@zashraf1985 zashraf1985 removed their assignment Jan 1, 2021
@zashraf1985 zashraf1985 marked this pull request as ready for review January 1, 2021 02:15
@zashraf1985 zashraf1985 changed the title Attempting to fix remaining vulnerabilities chore: Exclude dev dependencies from sourc clear check Jan 1, 2021
@zashraf1985 zashraf1985 changed the title chore: Exclude dev dependencies from sourc clear check chore: Exclude dev dependencies from source clear check Jan 1, 2021
@zashraf1985 zashraf1985 requested a review from mjc1283 January 4, 2021 18:06
@zashraf1985 zashraf1985 requested a review from yavorona February 22, 2021 18:35
@zashraf1985 zashraf1985 merged commit ede1ece into master Feb 22, 2021
@zashraf1985 zashraf1985 deleted the zeeshan/fix-more-vulnarabilities branch February 22, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants