Skip to content

Conversation

junaed-optimizely
Copy link
Contributor

Summary

If the project does not have ODP integration enabled, sdk should not call the fetchQualifiedSegments method.

Test plan

Existing test should pass

Issues

FSSDK-10198

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@junaed-optimizely junaed-optimizely changed the title Junaed/fssdk 10198 odp not integrated error [FSSDK-10198] odp not integrated error May 21, 2024
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the dependencies.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please check your specific error is corrected. You might also note that in the PR description as part of manual acceptance testing.

@junaed-optimizely junaed-optimizely merged commit d2f14bd into master May 22, 2024
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10198-odp-not-integrated-error branch May 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants