Skip to content

refactor: remove unnecessary python 2 deps/syntax #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 3, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Updated format functions to f-strings
  • Removed unnecessary dependencies
  • Removed redundant super parameters and object baseclass
  • Removed deprecated threading method
  • Removed unnecessary py2 patches
  • Updated setup.py versions

Modernize syntax, increase readability, decrease non standard library dependencies

Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Have you ran the linter?
  2. pypy tests on CI are failing, I guess that's because this branch doesn't have the fix for pypy yet?

Approved, but pls check out the comments.

@andrewleap-optimizely andrewleap-optimizely merged commit 3b1a622 into master Jun 3, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/cleanup_python_2 branch June 3, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants