Skip to content

ci: Install a compatible version of cryptography for pypy and pypy3 in travis config #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2021
Merged

ci: Install a compatible version of cryptography for pypy and pypy3 in travis config #320

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c28a231
try explicitly
msohailhussain Mar 4, 2021
2f292c2
try installing in before install
oakbani Mar 5, 2021
c92b6b2
add pyyp3 and comment.
oakbani Mar 5, 2021
4722bf6
Update README.md
Mat001 Mar 5, 2021
61b39c1
Update README.md
Mat001 Mar 5, 2021
b6e5e38
a to the
oakbani Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ python:
- "3.6"
# - "3.7" is handled in 'Test' job using xenial as Python 3.7 is not available for trusty.
# - "3.8" is handled in 'Test' job using xenial as Python 3.8 is not available for trusty.
- "pypy"
- "pypy3"
# - "pypy"
# - "pypy3"
install: "pip install -r requirements/core.txt;pip install -r requirements/test.txt"
script: "pytest --cov=optimizely"
after_success:
Expand Down Expand Up @@ -61,7 +61,14 @@ jobs:
SDK=python
SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH
FULLSTACK_TEST_REPO=ProdTesting

- stage: 'Test'
python: "pypy"
before_install:
- pip install "cryptography>=1.3.4,<=3.1.1" # installing in before_install doesn't re-install a latest version of the same package in the next stage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix grammatical error: Change "a latest version of the same" to "the latest version of the same".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- stage: 'Test'
python: "pypy3"
before_install:
- pip install "cryptography>=1.3.4,<=3.1.1"
- stage: 'Test'
dist: xenial
python: "3.7"
Expand Down