Skip to content

(fix): refactor batch_event_processor to reset deadline after it passes. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 14, 2019
Merged

(fix): refactor batch_event_processor to reset deadline after it passes. #227

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
71b849f
refactor batch_event_processor to reset deadline after it passes. Als…
thomaszurkan-optimizely Dec 12, 2019
124fd85
fix lint error
thomaszurkan-optimizely Dec 12, 2019
078f6e7
lint
thomaszurkan-optimizely Dec 12, 2019
c66db1b
fix lint error
thomaszurkan-optimizely Dec 12, 2019
a9a15ac
finally got to debug replacing the mock logger
thomaszurkan-optimizely Dec 12, 2019
c681c1c
update to take time in float
thomaszurkan-optimizely Dec 13, 2019
d7b09eb
add unit tests for float flush deadline and flush interval
thomaszurkan-optimizely Dec 13, 2019
1aebafd
fix broken test
thomaszurkan-optimizely Dec 13, 2019
c772b3e
update method description
thomaszurkan-optimizely Dec 13, 2019
0e1276d
added a unit test to make sure processor is called once during flush …
thomaszurkan-optimizely Dec 13, 2019
94f52e1
lint error
thomaszurkan-optimizely Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint error
  • Loading branch information
@thomaszurkan-optimizely
thomaszurkan-optimizely committed Dec 12, 2019
commit c66db1b37638229a021a9d0f9a23fec2f3a44907
3 changes: 2 additions & 1 deletion optimizely/event/event_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,8 @@ def _run(self):
while True:
if self._get_time() >= self.flushing_interval_deadline:
self._flush_queue()
self.flushing_interval_deadline = self._get_time() + self._get_time(self.flush_interval.total_seconds())
self.flushing_interval_deadline = self._get_time() + \
self._get_time(self.flush_interval.total_seconds())

try:
interval = self._get_time(self.flush_interval.total_seconds()) - self._get_time()
Expand Down