Skip to content

feat(DecisionListener): Adds feature variables decision listener. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2019
Merged

feat(DecisionListener): Adds feature variables decision listener. #170

merged 4 commits into from
Apr 4, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

Implemented onDecisionListener in get feature variable APIs.

Test plan

Unit tests for DecisionListener

Issues

  • OASIS-4352

@rashidsp rashidsp changed the title feat: decision listener for get feature variable * feat(DecisionListener): Adds feature variables decision listener. Mar 28, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.71% when pulling 6339201 on oakbani/decision-get-feature-variable into f772ecc on master.

@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.713% when pulling 73853d1 on oakbani/decision-get-feature-variable into e4d949a on master.

@rashidsp rashidsp requested a review from a team March 29, 2019 05:11
@aliabbasrizvi
Copy link
Contributor

@rashidsp can you help resolve the conflicts here?

@rashidsp
Copy link
Contributor Author

rashidsp commented Apr 3, 2019

@aliabbasrizvi Conflicts resolved.

aliabbasrizvi
aliabbasrizvi approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit 42f2eb0 into master Apr 4, 2019
@aliabbasrizvi aliabbasrizvi deleted the oakbani/decision-get-feature-variable branch April 4, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @aliabbasrizvi @oakbani