Skip to content

test (test data): Fix variation keys for multi experiments dict #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2018
Merged

test (test data): Fix variation keys for multi experiments dict #138

merged 1 commit into from
Aug 28, 2018

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Aug 28, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 99.747% when pulling 320afc9 on oakbani/fix-datafile-vals into 84736de on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 99.747% when pulling 320afc9 on oakbani/fix-datafile-vals into 84736de on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 99.747% when pulling 320afc9 on oakbani/fix-datafile-vals into 84736de on master.

mikeproeng37
mikeproeng37 approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this fixes a mismatch between the variation ids within the same experiment

@mikeproeng37 mikeproeng37 merged commit 56a64e8 into master Aug 28, 2018
@oakbani oakbani deleted the oakbani/fix-datafile-vals branch August 29, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oakbani @coveralls @mikeproeng37