Skip to content

chore: Removed Monolog version restriction #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 22, 2021
Merged

chore: Removed Monolog version restriction #235

merged 6 commits into from
Nov 22, 2021

Conversation

ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Nov 10, 2021 •
edited by zashraf1985
Loading

Summary

  • Monolog and guzzlehttp/guzzle version restriction removed.

Test plan

All Existing unit and Integration tests pass

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.302% when pulling e453673 on uzair/php-to-7.4 into 0e7cefc on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.302% when pulling e453673 on uzair/php-to-7.4 into 0e7cefc on master.

@coveralls
Copy link

coveralls commented Nov 12, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 97.789% when pulling 20f17c5 on uzair/php-to-7.4 into 0e7cefc on master.

@zashraf1985 zashraf1985 changed the title feat: Monolog update feat: Removed Monolog version restriction Nov 22, 2021
@zashraf1985 zashraf1985 marked this pull request as ready for review November 22, 2021 20:47
@zashraf1985 zashraf1985 requested a review from a team as a code owner November 22, 2021 20:47
zashraf1985
zashraf1985 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zashraf1985 zashraf1985 changed the title feat: Removed Monolog version restriction chore: Removed Monolog version restriction Nov 22, 2021
@zashraf1985 zashraf1985 merged commit e5bfc38 into master Nov 22, 2021
@zashraf1985 zashraf1985 deleted the uzair/php-to-7.4 branch November 22, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozayr-zaviar @coveralls @zashraf1985