-
Notifications
You must be signed in to change notification settings - Fork 30
feat(ForcedDecisions): add forced-decisions APIs to OptimizelyUserContext #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
8607ff2
Work in progress
NomanShoaib e013fea
fix
NomanShoaib 0b1f517
implemented forcedDecision
NomanShoaib cd4176c
fixed issues
NomanShoaib 5c753aa
fixed all errors
NomanShoaib 0fd717b
fixed old tests and logs errors
NomanShoaib 7e2400f
fix
NomanShoaib 9cb1d03
fix
NomanShoaib ae48a61
added remove forcedecision removeall force decision apis
NomanShoaib 6a9a5f0
Unit tests added and fixed some bugs
NomanShoaib 60ae438
Added unit tests of forceddecision
NomanShoaib df1c82f
Comments fixed
NomanShoaib 80e5026
return true in removeallforcedecision even if forceddecision list is …
NomanShoaib 979a0e7
Added depreciation warning in
NomanShoaib d22ad11
Fixed experimentId null or empty error in impression event
NomanShoaib a5843c2
fixed logging and !=null comments
NomanShoaib f387f89
lint fix
NomanShoaib 3557793
removed depreciation warning
NomanShoaib 8797195
made rule key compulsory instead of optional and moved it to 2nd arg …
NomanShoaib 83ef326
- moved the two methods of remove and remove all forceddecision after…
NomanShoaib b7b980d
Added Decided by forceddecision reason
NomanShoaib 280371c
Added reasons in test case
NomanShoaib 9168430
DatafileprojectConfig line 248 added verification that redundant vari…
NomanShoaib 2bb8937
fixed logging and unit tests
NomanShoaib 0df9732
lint fix
NomanShoaib bc3bb03
OptimizelyDecisionContext and OptimizelyForcedDecision implemented
ozayr-zaviar 7566d55
impression corrected (#234)
ozayr-zaviar 32122b7
comments addressed
ozayr-zaviar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implication of these new interface functions to existing clients with custom ProjectConfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will simply return flag variations map do i have to add something other then comment above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I think it's good as is.