Support OPTIMIZELY_DATA_DIR envar + some cleanup #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaschachar
approved these changes
Jul 28, 2020
| read_data(decisions_dir, "decisions") | ||
| ``` | ||
|
|
||
| Reading decisions data from data/type=decisions |
There was a problem hiding this comment.
Is this intended to be a header for the content above?
There was a problem hiding this comment.
No; this was print output from the read_data function. I agree it looks confusing in the markdown file, so I removed it from the notebook.
| .getOrCreate() | ||
| ``` | ||
|
|
||
| ## Loading enriched event data |
There was a problem hiding this comment.
nit capitalization: Enriched Event data
| ## Loading enriched event data | ||
|
|
||
| We'll start by loading decision and conversion data from `/data`. | ||
| The `OPTIMIZELY_DATA_DIR` environment variable may be used to specify the local directory where Enriched Event Data is stored. If, for example, you've downloaded Enriched Event data and saved it in `optimizely_data` in your home directory, you can load that data in this notebook by executing the following command before launching Jupyter Lab: |
There was a problem hiding this comment.
nit: Enriched Event data
koomen
pushed a commit
that referenced
this pull request
May 10, 2022
Update crazyegg installation instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.