Skip to content

Fix image URLs in index.md, and add logic to do this in build.sh #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fix image URLs in index.md, and add logic to do this in build.sh #17

merged 1 commit into from
Sep 16, 2020

Conversation

koomen
Copy link
Contributor

@koomen koomen commented Sep 16, 2020

No description provided.

@koomen koomen requested a review from asaschachar September 16, 2020 22:56
asaschachar
asaschachar approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@asaschachar asaschachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice regex! Thanks for doing that. In a future PR, we could move this regex to the contentful upload process so all labs get the benefits of relative to absolute url conversion.

@koomen koomen merged commit ad5d0b1 into master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asaschachar asaschachar asaschachar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koomen @asaschachar