Skip to content

[FSSDK-9621] add persistentCacheProvider option for instantiation #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • make the react native persistent cache implementation configurable

Test plan

  • added relevant tests

Issues

  • FSSDK-9621

@coveralls
Copy link

coveralls commented Mar 14, 2024

Coverage Status

coverage: 90.374%. remained the same
when pulling 4b4bc68 on raju/configurable-cache
into 7283019 on master.

@mikechu-optimizely
Copy link
Contributor

@anton-patrushev Was this what you had in mind for your posted issue?

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think it's worthwhile to spin up an Expo project and include this branch's dist for manual testing and pass in our own store.

@muzahidul-opti
Copy link

Do we need to support both? If mmkv meets our requirements, perhaps we can gradually discontinue async-storage.

@raju-opti
Copy link
Contributor Author

Do we need to support both? If mmkv meets our requirements, perhaps we can gradually discontinue async-storage.

@muzahidul-opti this PR allows the user to provide their own peristentCache, so that they can use anything they like. By default we are still using async-storage.

@mikechu-optimizely
Copy link
Contributor

Do we need to support both? If mmkv meets our requirements, perhaps we can gradually discontinue async-storage.

Good qustion @muzahidul-opti . Thanks for asking it.

@raju-opti raju-opti merged commit 05547df into master Mar 18, 2024
@raju-opti raju-opti deleted the raju/configurable-cache branch March 18, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants