Skip to content

[FSSDK-9621] remove duplicate reactNativeAsyncStorageCache #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2024
Merged

[FSSDK-9621] remove duplicate reactNativeAsyncStorageCache #913

merged 2 commits into from
Mar 12, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • There were multiple implementations of reactNativeAsyncStorageCache which was doing the same thing.

Test plan

  • refactored tests accordingly

Issues

  • FSSDK-9621

@raju-opti raju-opti requested a review from a team as a code owner March 12, 2024 12:03
@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited
Loading

Coverage Status

coverage: 90.374% (+0.001%) from 90.373%
when pulling 7ee985c on raju/rn-async
into a1658d0 on master.

mikechu-optimizely
mikechu-optimizely requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying. Just small things below.

mikechu-optimizely
mikechu-optimizely approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 7283019 into master Mar 12, 2024
@raju-opti raju-opti deleted the raju/rn-async branch March 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely