Skip to content

Update contribution doc to use CLA #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Conversation

mikeproeng37
Copy link
Contributor

Summary: Update contribution doc to use CLA

Test Plan: Manual

Reviewers: haley.bash, ali, vignesh, delikat

Differential Revision: https://phabricator.optimizely.com/D13038
Copy link
Contributor

@haleybash-optimizely haleybash-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit c5bca24 into devel Sep 28, 2016
@mikeproeng37 mikeproeng37 deleted the mng/add-contribution-cla branch September 28, 2016 20:37
mikeproeng37 added a commit that referenced this pull request Oct 3, 2016
* Replace bluebird dependency with smaller es6-promise library.

* Update contribution doc to use CLA (#9)

Update contribution doc to use CLA

* Bump version to 1.0.0 (#10)

Bump version to 1.0.0
mjc1283 added a commit that referenced this pull request Apr 22, 2019
…h objects instead of strings. Add StaticDatafileManager. (#9)

Summary:

- DatafileManager interface uses objects instead of strings
- HttpPollingDatafileManager uses JSON.parse on response bodies
- Added StaticDatafileManager as a top level export (will be used in optimizely-sdk)

Test plan:

Updated unit tests & added new unit tests.

Issues:
https://optimizely.atlassian.net/browse/OASIS-4384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants