Skip to content

Bundler-friendly entry point #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DullReferenceException
Copy link
Contributor

  • Use the browser entry point instead of a webpack build for browser in package.json (see the intended use of the browser package.json field for justification).
  • Loosen lodash & uuid version requirements to increase potential for package reuse by bundlers

* Use the browser entry point instead of a webpack build for `browser` in `package.json` (see [the intended use of the browser package.json field](https://github.com/defunctzombie/package-browser-field-spec) for justification).
* Loosen lodash & uuid version requirements to increase potential for package reuse by bundlers
@optibot
Copy link

optibot commented Apr 12, 2018

Can one of the admins verify this patch?

@mikeproeng37
Copy link
Contributor

Thanks! Will take a look shortly.

@mikeproeng37
Copy link
Contributor

build

@mikeproeng37
Copy link
Contributor

Could you also please sign the CLA as mentioned in our Contributing.md doc?

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 799de3c into optimizely:master Apr 13, 2018
@mikeproeng37
Copy link
Contributor

I've merged this in. Will likely deploy out next week. Thanks again!

@DullReferenceException DullReferenceException deleted the improve-bundling branch April 13, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants