-
Notifications
You must be signed in to change notification settings - Fork 83
[FSSDK-9611] fix relative import paths that goes out of lib #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are bundling our package, and type definiton of all our dependencies are in dev-dependencies as they should be and therefore not installed when clients install our sdk.compiling our lib files will need those type definitions. so files in our dist must not refer to the lib files, but some of them do refer to the lib files. and consumers are getting missing types as a result. files in /dist was referring to files in /lib because some relative import paths were going out of lib and then back in. as the path strings were preserved in the built files in dist, it was going out of /dist and into /lib. This commit fixes those relative import paths to stay inside /lib
mikechu-optimizely
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refining. We'll need to handle a few copyright additions/updates but LGTM.
Thanks for hoping on this fix for #855 @raju-opti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
files in /dist was referring to files in /lib because some relative import paths were going out of lib and then back in. as the path strings were preserved in the built files in dist, it was going out of /dist and into /lib.
This commit fixes those relative import paths to stay inside /lib
Test plan
Issues