Skip to content

[FSSDK-9611] fix relative import paths that goes out of lib #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • we are bundling our package, and type definiton of all our dependencies are in dev-dependencies as they should be and therefore not installed when clients install our sdk.compiling our lib files will need those type definitions. so files in our dist must not refer to the lib files, but some of them do refer to the lib files. and consumers are getting missing types as a result.

files in /dist was referring to files in /lib because some relative import paths were going out of lib and then back in. as the path strings were preserved in the built files in dist, it was going out of /dist and into /lib.

This commit fixes those relative import paths to stay inside /lib

Test plan

  • all existing tests should pass

Issues

  • FSSDK-9611

we are bundling our package, and type definiton of all our dependencies are in dev-dependencies as they should be and therefore not installed when clients install our sdk.compiling our lib files will need those type definitions. so files in our dist must not refer to the lib files, but some of them do refer to the lib files. and consumers are getting missing types as a result.

files in /dist was referring to files in /lib because some relative import paths
were going out of lib and then back in. as the path strings were
preserved in the built files in dist, it was going out of /dist and into
/lib.

This commit fixes those relative import paths to stay inside /lib
@coveralls
Copy link

coveralls commented Aug 22, 2023

Coverage Status

coverage: 90.454%. remained the same when pulling f6f65fd on raju/type-fix into b85af27 on master.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refining. We'll need to handle a few copyright additions/updates but LGTM.

@mikechu-optimizely
Copy link
Contributor

Thanks for hoping on this fix for #855 @raju-opti

@raju-opti raju-opti merged commit b317068 into master Aug 22, 2023
@raju-opti raju-opti deleted the raju/type-fix branch August 22, 2023 17:47
raju-opti added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants