Skip to content

[FSSDK-8219] moved optimizely-sdk package to repository root #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2023
Merged

[FSSDK-8219] moved optimizely-sdk package to repository root #851

merged 3 commits into from
Aug 17, 2023

Conversation

@raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Aug 16, 2023

Summary

  • moved optimizely-sdk package to repository root

Test plan

  • existing unit, umd and crossbrowser tests should pass. Integration tests will fail until testapp is updated to point to updated package path.

Issues

  • FSSDK-8219

@raju-opti raju-opti requested a review from a team as a code owner August 16, 2023 14:42
@raju-opti raju-opti marked this pull request as draft August 16, 2023 14:43
@raju-opti raju-opti changed the title Raju/move to root [FSSDK-8219] moved optimizely-sdk package to repository root Aug 16, 2023
@coveralls
Copy link

coveralls commented Aug 16, 2023

Coverage Status

coverage: 90.437%. remained the same when pulling f078a7b on raju/move-to-root into 59c5a08 on master.

@raju-opti raju-opti marked this pull request as ready for review August 16, 2023 15:04
mikechu-optimizely
mikechu-optimizely approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 91826b0 into master Aug 17, 2023
@raju-opti raju-opti deleted the raju/move-to-root branch August 17, 2023 07:43
@mikechu-optimizely mikechu-optimizely mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raju-opti @coveralls @mikechu-optimizely