Skip to content

[FSSDK-8219] consolidate tsconfig.json #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

[FSSDK-8219] consolidate tsconfig.json #850

merged 1 commit into from
Aug 16, 2023

Conversation

@raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Aug 16, 2023

Summary

  • previously there was a tsconfig.json in the repository root which was being extended by packages/optimizely-sdk/tsconfig.json. This PR removes the root config and moves all settings to packages/optimizely-sdk/tsconfig.json

Test plan

  • all existing tests should pass

Issues

  • FSSDK-8219

@raju-opti raju-opti requested a review from a team as a code owner August 16, 2023 12:36
@raju-opti raju-opti force-pushed the raju/consolidate-tsconfig branch from 249f0fd to bb9d114 Compare August 16, 2023 12:37
@coveralls
Copy link

coveralls commented Aug 16, 2023 •
edited
Loading

Coverage Status

coverage: 90.437%. remained the same when pulling bb9d114 on raju/consolidate-tsconfig into cf0aa8c on master.

mikechu-optimizely
mikechu-optimizely approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 question to review but not show stopper I'd think

@raju-opti raju-opti merged commit 59c5a08 into master Aug 16, 2023
@raju-opti raju-opti deleted the raju/consolidate-tsconfig branch August 16, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raju-opti @coveralls @mikechu-optimizely