Skip to content

[FSSDK-9490] Prepare for release 5.0.0-beta.2 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

[FSSDK-9490] Prepare for release 5.0.0-beta.2 #835

merged 2 commits into from
Jul 20, 2023

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Jul 19, 2023 •
edited
Loading

Summary

  • release 5.0.0-beta2

Test plan

Issues

  • FSSDK-9490

@raju-opti raju-opti requested a review from a team as a code owner July 19, 2023 13:09
@raju-opti raju-opti assigned jaeopt and unassigned jaeopt and raju-opti Jul 19, 2023
mikechu-optimizely
mikechu-optimizely approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the below conversation

@coveralls
Copy link

coveralls commented Jul 19, 2023 •
edited
Loading

Coverage Status

coverage: 90.521%. remained the same when pulling b7cddbd on raju/prepare-5.0.0-beta.2 into 6b88aaf on master.

jaeopt
jaeopt requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. version naming suggested.

@raju-opti raju-opti requested a review from jaeopt July 19, 2023 18:17
jaeopt
jaeopt approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit f75f1f9 into master Jul 20, 2023
@raju-opti raju-opti deleted the raju/prepare-5.0.0-beta.2 branch July 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@jaeopt jaeopt

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raju-opti @coveralls @jaeopt @mikechu-optimizely