Skip to content

[FSSDK-9416] Refactor dependent promises typing in client onReady #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2023
Merged

[FSSDK-9416] Refactor dependent promises typing in client onReady #834

merged 2 commits into from
Jul 8, 2023

Conversation

raju-opti
Copy link
Contributor

Summary

  • eventProcessorStartedPromise actually is typed as void in the Managed interface, but has a Promise implementation in the extended EventProcessor interface. This PR fixes that.

Test plan

  • All existing tests should pass

Issues

@raju-opti raju-opti requested a review from a team as a code owner July 7, 2023 19:06
@raju-opti raju-opti assigned jaeopt and unassigned raju-opti Jul 7, 2023
jaeopt
jaeopt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 90.521% (+0.006%) from 90.515% when pulling b3ab95d on raju/refactor-dependent-promise-async into 2f75caf on master.

@raju-opti raju-opti merged commit 6b88aaf into master Jul 8, 2023
@raju-opti raju-opti deleted the raju/refactor-dependent-promise-async branch July 8, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely Awaiting requested review from mikechu-optimizely

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @jaeopt