Skip to content

[FSSDK-9362] chore: ODP code & comment adjustments #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

[FSSDK-9362] chore: ODP code & comment adjustments #827

merged 1 commit into from
May 30, 2023

Conversation

opti-jnguyen
Copy link
Contributor

Summary

  • First iteration of cleaning up of various tests, comments, and code related to new ODP feature
  • Enhanced implementation of the VUID initialization promise dependency for Optimizely Client's initPromise promise dependency array

Test plan

  • All existing tests should pass
  • New promise dependency array functionality should be tested

Issues

@coveralls
Copy link

Coverage Status

Coverage: 90.515% (+0.05%) from 90.462% when pulling 99bcfc8 on jnguyen/odp-cleanup-1 into b5e6d99 on master.

@opti-jnguyen opti-jnguyen marked this pull request as ready for review May 26, 2023 16:34
@opti-jnguyen opti-jnguyen requested a review from a team as a code owner May 26, 2023 16:34
mikechu-optimizely
mikechu-optimizely approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts, but otherwise LGTM.

@opti-jnguyen opti-jnguyen merged commit ac00afc into master May 30, 2023
@opti-jnguyen opti-jnguyen deleted the jnguyen/odp-cleanup-1 branch May 30, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@raju-opti raju-opti Awaiting requested review from raju-opti

Assignees

@opti-jnguyen opti-jnguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opti-jnguyen @coveralls @mikechu-optimizely