feat(ats): [FSSDK-8690] fix configurable ODP request timeouts #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasirfolio3
approved these changes
Mar 23, 2023
| const browserOdpManager = new BrowserOdpManager({}); | ||
|
|
||
| // @ts-ignore | ||
| expect(browserOdpManager.segmentManager.odpSegmentApiManager.requestHandler.timeout).toBe(10000); |
There was a problem hiding this comment.
can we use REQUEST_TIMEOUT_ODP_SEGMENTS_MS here? same for the other test.
There was a problem hiding this comment.
I agree that comparing against the variable will improve test reliability when adjusting the timeout. In this case, I intentionally check against the number to protect from unintended constant changes :)
opti-jnguyen
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support configurable timeouts for ODP segment and event requests.
Use default timeout of 10 secs if not configured.
Test plan
Issues