Skip to content

chore: Language versions update #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 15, 2022
Merged

Conversation

shaharyar123
Copy link
Contributor

@shaharyar123 shaharyar123 commented Aug 4, 2022

Summary

Updated Minimum versions of the following

Typescript: 4.7.4
Node: 14

Browsers:
Chrome: 102.0
Edge: 84.0
Firefox: 91.0
Opera: 76.0
Safari: 13.0

Test plan

All unit tests and Full stack compatibility suite tests pass.

Ticket

OASIS-8467

@coveralls
Copy link

coveralls commented Aug 5, 2022

Coverage Status

Coverage remained the same at 96.832% when pulling d33d11b on sherry/language-versions-updates into e4b5dc9 on master.

Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! Please remove support for node 12 too.

@@ -44,6 +44,7 @@
"@optimizely/js-sdk-event-processor": "^0.9.2",
"json-schema": "^0.4.0",
"murmurhash": "^2.0.1",
"tslib": "^2.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in devDependencies

@zashraf1985 zashraf1985 changed the title Language versions update chore: Language versions update Aug 12, 2022
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for upgrading the node and typescript versions to latest.

@zashraf1985 zashraf1985 merged commit efe2f6c into master Aug 15, 2022
@zashraf1985 zashraf1985 deleted the sherry/language-versions-updates branch August 15, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants