-
Notifications
You must be signed in to change notification settings - Fork 83
chore: Language versions update #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! Please remove support for node 12 too.
packages/optimizely-sdk/package.json
Outdated
@@ -44,6 +44,7 @@ | |||
"@optimizely/js-sdk-event-processor": "^0.9.2", | |||
"json-schema": "^0.4.0", | |||
"murmurhash": "^2.0.1", | |||
"tslib": "^2.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be in devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for upgrading the node and typescript versions to latest.
Summary
Updated Minimum versions of the following
Typescript:
4.7.4
Node:
14
Browsers:
Chrome:
102.0
Edge:
84.0
Firefox:
91.0
Opera:
76.0
Safari:
13.0
Test plan
All unit tests and Full stack compatibility suite tests pass.
Ticket
OASIS-8467