refactor: Integrate logging package #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
suggested changes
Jun 8, 2022
| @@ -13,14 +13,13 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| import logHelper from './modules/logging/logger'; | |||
There was a problem hiding this comment.
Why did you need to introduce the concept of logHelper here. Why importing directly from ./modules/loggin does not work?
There was a problem hiding this comment.
Karma browser test was not able to locate the package unless it is defined in the default.
zashraf1985
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
LGTM! @opti-jnguyen @mikechu-optimizely it will be helpful if you guys can also take a look and provide feedback on this.
|
Added a couple comments @ozayr-zaviar - let me know what you think. cc: @zashraf1985 |
opti-jnguyen
approved these changes
Jun 23, 2022
zashraf1985
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
optimizely-sdkpackage.Test plan
Jira
OASIS-8204