Skip to content

fix: follow experimentIds order of experiments inside featuresMap of OptimizelyConfig #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

fix: follow experimentIds order of experiments inside featuresMap of OptimizelyConfig #701

merged 1 commit into from
Sep 1, 2021

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Aug 31, 2021 •
edited
Loading

Summary

  • Fix order of experiments inside featuresMap in OptimizelyConfig to match the order of experimentIds in datafile.

Test plan

Unit tests + FSC + local bundle

Issues

@yavorona yavorona marked this pull request as ready for review August 31, 2021 23:37
@yavorona yavorona requested a review from a team as a code owner August 31, 2021 23:37
@yavorona yavorona removed their assignment Aug 31, 2021
jaeopt
jaeopt approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

msohailhussain
msohailhussain approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yavorona yavorona merged commit a17fd9a into master Sep 1, 2021
@yavorona yavorona deleted the pnguen/fix-experiment-order branch September 1, 2021 01:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0009%) to 97.001% when pulling cedafe9 on pnguen/fix-experiment-order into 2dc56bc on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yavorona @coveralls @msohailhussain @jaeopt