Skip to content

fix: Replace secured tokens with ENV vars #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Conversation

msohailhussain
Copy link
Contributor

Summary

  • Replaced security tokens with ENV vars.

Test plan

https://app.travis-ci.com/github/optimizely/javascript-sdk/builds/236234712

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.002% when pulling 2e0f67a on sohail/removetokens into d32c80f on master.

@msohailhussain msohailhussain merged commit 2dc56bc into master Aug 26, 2021
@msohailhussain msohailhussain deleted the sohail/removetokens branch August 26, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants