Replace bluebird dependency with smaller es6-promise library. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we make a |
jordangarcia
pushed a commit
that referenced
this pull request
Jan 25, 2019
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
…s or non-success response status (#7) Summary: Implement an increasing delay for the next request after a response Promise is rejected, or resolved with a non-successful status. If the configured updateInterval is greater than the calculated delay, we just use the updateInterval. Test plan: Added unit tests for new module backoffController. Added unit tests for httpPollingDatafileManager backoff functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@haleybash-optimizely @aliabbasrizvi @delikat @vignesh-optimizely @wangjoshuah @jophde
This reduces the size of our minified bundle from 180kb to 113kb.