feat: Use enum to define type in getTypeCastValue #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keppel2
reviewed
Jul 26, 2021
| @@ -582,9 +583,10 @@ export const getVariableValueForVariation = function( | |||
| * @returns {*} Variable value of the appropriate type, or | |||
| * null if the type cast failed | |||
| */ | |||
|
|
|||
zashraf1985
suggested changes
Jul 26, 2021
| @@ -203,7 +204,7 @@ export const createProjectConfig = function( | |||
| // Converting it to a first-class json type while creating Project Config | |||
| feature.variables.forEach((variable) => { | |||
| if (variable.type === FEATURE_VARIABLE_TYPES.STRING && variable.subType === FEATURE_VARIABLE_TYPES.JSON) { | |||
| variable.type = FEATURE_VARIABLE_TYPES.JSON; | |||
There was a problem hiding this comment.
why is this explicit cast needed for the json value but it works otherwise for other values without casting?
There was a problem hiding this comment.
I believe there is no otherwise cases of setting a value of variable.type besides this one. The FEATURE_VARIABLE_TYPES.JSON is type string and variable.type is expected to be VariableType so we needed to case it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use enum to define type in getTypeCastValue in project_config
Issues