WIP: Added new Optimizely config fields (DO NOT REVIEW) #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasirfolio3
suggested changes
Jul 6, 2021
| @@ -22,6 +22,9 @@ import { | |||
| VariationVariable, | |||
| Variation, | |||
| Rollout, | |||
| OptimizelyAttribute, | |||
| OptimizelyAudience, | |||
| OptimizelyEvents | |||
There was a problem hiding this comment.
Should be OptimizelyEvent
| @@ -145,5 +145,13 @@ describe('lib/core/optimizely_config', function() { | |||
| it('should return correct config environmentKey ', function() { | |||
| assert.equal(optimizelyConfigObject.environmentKey, datafile.environmentKey); | |||
| }); | |||
|
|
|||
| it('should return correct config attributes', function() { | |||
| @@ -38,15 +41,51 @@ export class OptimizelyConfig { | |||
| public featuresMap: OptimizelyFeaturesMap; | |||
| public revision: string; | |||
| public sdkKey?: string; | |||
| public attributes: OptimizelyAttribute[]; | |||
| public audiences: OptimizelyAudience[]; | |||
| public events: OptimizelyEvents[]; | |||
There was a problem hiding this comment.
Please fix this too, this should be OptimizelyEvent[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
Test plan
Issues