Skip to content

feat: Convert event builder module to TS #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 16, 2021
Merged

feat: Convert event builder module to TS #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
074d2bc
Convert event_builder
yavorona Jun 8, 2021
3489111
Clean up
yavorona Jun 8, 2021
a2affb3
WIP
yavorona Jun 9, 2021
e3e681e
Convert event_helpers
yavorona Jun 9, 2021
cc6ef79
More cleanup
yavorona Jun 9, 2021
3a88fe2
Incorporate comments
yavorona Jun 11, 2021
1c39080
Upgrade event-processor to v0.8.2
yavorona Jun 14, 2021
316d5e0
NIT
yavorona Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Bug fixes
- Bumped `event-processor` packages to version `0.8.2`.

## [4.6.0] - May 27, 2021

### New Features
Expand Down
116 changes: 0 additions & 116 deletions packages/optimizely-sdk/lib/core/event_builder/event_helpers.d.ts
View file
Open in desktop

This file was deleted.

185 changes: 0 additions & 185 deletions packages/optimizely-sdk/lib/core/event_builder/event_helpers.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/event_builder/event_helpers.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import sinon from 'sinon';
import { assert } from 'chai';

import fns from '../../utils/fns';
import projectConfig from '../project_config';
import * as projectConfig from '../project_config';
import { buildImpressionEvent, buildConversionEvent } from './event_helpers';

describe('lib/event_builder/event_helpers', function() {
Expand Down
Loading