Skip to content

fix: Change to optimizely-sdk directory prior to running Source Clear #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

fix: Change to optimizely-sdk directory prior to running Source Clear #562

merged 1 commit into from
Sep 9, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Sep 9, 2020

Summary

Prior to running Source Clear build step, change into optimizely-sdk directory

Test plan

N/A

@mjc1283 mjc1283 marked this pull request as ready for review September 9, 2020 18:09
@mjc1283 mjc1283 requested a review from a team as a code owner September 9, 2020 18:09
@coveralls
Copy link

coveralls commented Sep 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.689% when pulling 7fa088e on mcarroll/source-clear-directory into 03b573e on master.

@msohailhussain msohailhussain force-pushed the mcarroll/source-clear-directory branch from 7fa088e to 696da6a Compare September 9, 2020 18:24
@mjc1283 mjc1283 assigned mjc1283 and unassigned mjc1283 Sep 9, 2020
mikeproeng37
mikeproeng37 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 28260a2 into master Sep 9, 2020
@mjc1283 mjc1283 deleted the mcarroll/source-clear-directory branch September 9, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37