Skip to content

docs: Update README.md description of unpkg snippet installation #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

Danny-Driscoll
Copy link
Contributor

@Danny-Driscoll Danny-Driscoll commented Jul 23, 2020

Summary

Adding readme language to clarify that there are downsides to installing via unpkg and it should not be our default recommended method.

Test plan

Just need feedback on language/framing

@Danny-Driscoll Danny-Driscoll requested a review from a team as a code owner July 23, 2020 23:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.71% when pulling 6feb0d8 on Danny-Driscoll-unpkg-caveat into b1e4596 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.71% when pulling 6feb0d8 on Danny-Driscoll-unpkg-caveat into b1e4596 on master.

@mjc1283 mjc1283 changed the title Update README.md docs: Update README.md description of unpkg snippet installation Jul 24, 2020
@mjc1283 mjc1283 merged commit dae32e0 into master Jul 24, 2020
@mjc1283 mjc1283 deleted the Danny-Driscoll-unpkg-caveat branch July 24, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants