feat: Convert user_profile_service_validator module to TS #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
changed the title
yavorona
force-pushed
the
pnguen/user-profile-service-validator-to-ts
branch
from
2c73ccf to
664fdb8
Compare
spham1412
approved these changes
Jul 20, 2020
aliabbasrizvi
approved these changes
Jul 20, 2020
| * @throws If the instance is not valid | ||
| */ | ||
| export var validate = function(userProfileServiceInstance) { | ||
| export function validate(userProfileServiceInstance: Record<string, unknown>): boolean { |
There was a problem hiding this comment.
This shouldn't be a Record! We should define an interface for UserProfileService instead
There was a problem hiding this comment.
UserProfileService interface has been declared in index.d.ts, so I tried importing it with
{ UserProfileService } from '@optimizely/optimizely-sdk' and import { UserProfileService } from '../../index', which did not work. Any suggestions on how to import it would be much appreciated! @mjc1283 @mikeng13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert
user_profile_service_validatormodule from JS to TS.Test plan