Skip to content

refactor: Removed dependency on lodash.cloneDeep #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2020
Merged

refactor: Removed dependency on lodash.cloneDeep #415

merged 2 commits into from
Mar 9, 2020

Conversation

fayyazarshad
Copy link
Contributor

@fayyazarshad fayyazarshad commented Feb 25, 2020 •
edited by zashraf1985
Loading

Summary

To reduce package size, we are gradually removing lodash library. This PR removes lodash.cloneDeep from optimizely-sdk package. It is still part of the repository but it is only being used to run tests. lodash has been removed from dependencies and moved to dev-dependencies in package.json

Test plan

All unit tests and Full Stack compatibility tests pass after this change

@fayyazarshad fayyazarshad self-assigned this Feb 25, 2020
@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 97.222% when pulling ecbaeaa on fayyaz/replace_lodash_cloneDeep into 026a21c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 97.563% when pulling 8619d26 on fayyaz/replace_lodash_cloneDeep into 31b5a4d on master.

zashraf1985
zashraf1985 reviewed Feb 25, 2020
View reviewed changes
@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_cloneDeep branch 2 times, most recently from fe84161 to 350d9fb Compare February 28, 2020 10:11
@fayyazarshad fayyazarshad changed the title Removed dependency on lodash.cloneDeep Removed dependency on lodash.cloneDeep WIP Please don't merge Feb 28, 2020
@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_cloneDeep branch from e27e196 to 33e0efc Compare March 3, 2020 13:12
@zashraf1985 zashraf1985 changed the title Removed dependency on lodash.cloneDeep WIP Please don't merge refactor: Removed dependency on lodash.cloneDeep Mar 3, 2020
@zashraf1985 zashraf1985 marked this pull request as ready for review March 3, 2020 21:34
@zashraf1985 zashraf1985 requested a review from a team as a code owner March 3, 2020 21:34
@zashraf1985 zashraf1985 removed the WIP label Mar 3, 2020
mjc1283
mjc1283 suggested changes Mar 5, 2020
View reviewed changes
@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_cloneDeep branch from f448bb1 to 0d1e6f2 Compare March 5, 2020 09:16
@fayyazarshad fayyazarshad reopened this Mar 5, 2020
@fayyazarshad fayyazarshad reopened this Mar 5, 2020
@fayyazarshad fayyazarshad reopened this Mar 5, 2020
@mjc1283 mjc1283 merged commit 5cf5ddc into master Mar 9, 2020
@mjc1283 mjc1283 deleted the fayyaz/replace_lodash_cloneDeep branch March 9, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@zashraf1985 zashraf1985 Awaiting requested review from zashraf1985

Assignees
No one assigned
Labels
🤖 12 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fayyazarshad @coveralls @mjc1283 @zashraf1985 @optimizely-codereview-bot