Skip to content

fix: Fix OptimizelyConfig TypeScript definitions #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix: Fix OptimizelyConfig TypeScript definitions #406

merged 1 commit into from
Feb 20, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Feb 20, 2020

Summary

Fix the type definitions for OptimizelyConfig. The value types in the various maps had an incorrect extra wrapper object.

Test plan

Manually tested in a local TS app

@mjc1283 mjc1283 requested a review from a team as a code owner February 20, 2020 00:34
@mjc1283 mjc1283 assigned mjc1283 and unassigned mjc1283 Feb 20, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.559% when pulling aaba946 on mcarroll/fix-optlyconfig-ts-definitions into 9fe10a0 on master.

mikeproeng37
mikeproeng37 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mjc1283 mjc1283 merged commit 90be2b9 into master Feb 20, 2020
@mjc1283 mjc1283 deleted the mcarroll/fix-optlyconfig-ts-definitions branch February 20, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37