Skip to content

Removed lodash.filter #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2020
Merged

Removed lodash.filter #398

merged 2 commits into from
Feb 21, 2020

Conversation

zashraf1985
Copy link
Contributor

Summary

Removed lodash.filter because it wasnt being used anywhere in the project. This is part of an effort to remove lodash dependency to reduce bundle size.

Test Plan

All Unit tests and Full Stack SDK compatibility passed

@coveralls
Copy link

coveralls commented Feb 18, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.559% when pulling 5f24b6f on zeeshan/removed-lodash-filter into 653296d on master.

@zashraf1985 zashraf1985 marked this pull request as ready for review February 18, 2020 06:17
@zashraf1985 zashraf1985 requested a review from a team as a code owner February 18, 2020 06:17
@mjc1283 mjc1283 merged commit 5a521db into master Feb 21, 2020
@mjc1283 mjc1283 deleted the zeeshan/removed-lodash-filter branch February 21, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @coveralls @mjc1283