fix (event processor) [OASIS-5907]: stop promise tracks in-flight dispatcher requests #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 17, 2020 15:46
| * limitations under the License. | ||
| */ | ||
|
|
||
| class RequestTracker { |
There was a problem hiding this comment.
Nit: please include a doc comment to describe this class
| try { | ||
| // swallow, an error stopping this queue should prevent this from stopping | ||
| return this.queue.stop() | ||
| this.queue.stop() |
There was a problem hiding this comment.
Should we be awaiting this also? Does it matter if onRequestsComplete resolves before this?
There was a problem hiding this comment.
I think it's redundant. The Promise returned from queue.stop is based on the request it triggers at that time, but all requests are also tracked by the RequestTracker.
|
Hi! Will this resolve #382? |
|
Hi @clementallen, Yes, we released v3.5.0 with this change and it should solve the issue. Thanks for the suggestion. If you could try it out and let us know how it's working for you, we'd appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tracking functionality to
EventProcessorfor every request sent by its dispatcher. This is implemented in aRequestTrackerclass.RequestTrackerexposes a method (onRequestsComplete) to get aPromisethat fulfills after the completion of requests in-flight at the time of the call.stopis updated to return the promise fromRequestTrackeronRequestsComplete.Test plan
Issues
https://optimizely.atlassian.net/browse/OASIS-5907