chore (Regression Test)[CJS-3815]: Add tests for passing in a custom condition evaluator #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesopti
commented
Jan 24, 2020
|
|
||
| describe('APIs', function() { | ||
| describe('evaluate', function() { | ||
| context('with default condition evaluator', function() { |
There was a problem hiding this comment.
None of the existing tests were changed in this PR. They were simply nested inside this context.
New tests at the bottom.
jamesopti
commented
Jan 24, 2020
| describe('Audience evaluation logging', function() { | ||
| var sandbox = sinon.sandbox.create(); | ||
|
|
||
| context('with additional custom condition evaluator', function() { |
jamesopti
changed the title
mjc1283
approved these changes
Jan 29, 2020
jamesopti
force-pushed
the
james/condition_evaluator_tests
branch
from
4c1b326 to
d06f24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#288 introduced an exploratory new feature, the ability to pass custom condition evaluators to the SDK constructor via the option
UNSTABLE_conditionEvaluators.The AudienceEvaluator (and its tests) were refactored as a part of that PR, but no tests were added to assert that the
UNSTABLE_conditionEvaluatorsworked when passed.This PR introduces tests to ensure that functionality continues to work.
Test plan
Unit tests added to assert that:
custom_attributeevaluatorIssues