feat: Run tests for sub packages in CI #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
force-pushed
the
zeeshan/multi-package-unit-tests
branch
from
c6c356b to
8b40939
Compare
zashraf1985
force-pushed
the
zeeshan/multi-package-unit-tests
branch
from
8b40939 to
01cfb98
Compare
zashraf1985
force-pushed
the
zeeshan/multi-package-unit-tests
branch
from
5322be5 to
605e08a
Compare
zashraf1985
changed the title
mjc1283
suggested changes
Dec 16, 2019
.travis.yml
Outdated
| stage: 'Test sub packages' | ||
| node_js: '12' | ||
| before_install: cd packages/datafile-manager | ||
| before_script: tsc |
There was a problem hiding this comment.
not needed. i just checked. looks like jest automatically compiles typescript before use
packages/utils/src/index.ts
Outdated
| @@ -62,7 +62,7 @@ export function objectValues<K>(obj: { [key: string]: K }): K[] { | |||
| return Object.keys(obj).map(key => obj[key]) | |||
| } | |||
|
|
|||
| export function objectEntries<K>(obj: { [key: string]: K }): [string, K][] { | |||
| export function objectEntries<K>(obj: { [key: string]: K }): (string | K)[][] { | |||
There was a problem hiding this comment.
This is fixing a tsc compilation error. return type was not correct.
mjc1283
suggested changes
Dec 17, 2019
packages/logging/package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "devDependencies": { | |||
| "@types/jest": "^23.3.12", | |||
| "jest": "^23.6.0", | |||
| "ts-jest": "^23.10.5" | |||
| "ts-jest": "^23.10.5", | |||
| "typescript": "^3.7.3" | |||
There was a problem hiding this comment.
Please change typescript dependency versions to "3.3.3333" in all packages
mjc1283
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Travis CI Only run tests for
optimizely-sdkpackage. This PR makes Travis CI run unit tests for other sub packages onnode 12Test Plan
Tested on Travis CI