Skip to content

chore: Update version of karma-browserstack-launcher #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2019
Merged

chore: Update version of karma-browserstack-launcher #367

merged 1 commit into from
Nov 14, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Nov 13, 2019

Summary

Upgrade version of dev dependency karma-browserstack-launcher to latest. Fixes issues running cross-browser tests in newer versions of Node.

Test plan

Run cross-browser tests

@mjc1283 mjc1283 requested a review from a team as a code owner November 13, 2019 20:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.601% when pulling a02fcf4 on mcarroll/update-karma-browserstack-launcher into 60bf1e8 on master.

@mjc1283 mjc1283 removed their assignment Nov 13, 2019
mikeproeng37
mikeproeng37 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mjc1283 mjc1283 merged commit 4845e50 into master Nov 14, 2019
@mjc1283 mjc1283 deleted the mcarroll/update-karma-browserstack-launcher branch April 13, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37