fix: log error message when user allocated to vacated space in group or experiment #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
reviewed
Nov 6, 2019
zashraf1985
reviewed
Nov 6, 2019
optimizely-codereview-bot
added
🤖 4 hrs
🤖 8 hrs
🤖 12 hrs
🤖 16 hrs
and removed
🤖 4 hrs
🤖 8 hrs
🤖 12 hrs
labels
mjc1283
approved these changes
Nov 12, 2019
…oup-or-experiment
mikeproeng37
deleted the
fayyaz/fix-log-message-vacated-space-in-group-or-experiment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user is allocated to space in a group that used to be occupied by an experiment, but is now unallocated, the JS SDK logs an error message. This is not an error, so it shouldn't log an error message.
Expected:
An info level message saying “User not in any experiment in group” should be logged
Actual:
An error level message saying 'Experiment ID " " is not in the datafile' is logged.