Skip to content

Update lodash dependency to ^4.17.11 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2019
Merged

Update lodash dependency to ^4.17.11 #297

merged 2 commits into from
Jun 27, 2019

Conversation

brandonhudavid
Copy link
Contributor

Summary

  • Updated lodash dependency in JS SDK to ^4.17.11

Addresses security vulnerabilities in lodash versions < 4.17.11

Test plan

  • Run unit tests with mocha
  • Run unit tests with BrowserStack

Issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.531% when pulling ec6c4cf on lodash_version into ed884fb on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.531% when pulling ec6c4cf on lodash_version into ed884fb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.531% when pulling ec6c4cf on lodash_version into ed884fb on master.

@coveralls
Copy link

coveralls commented Jun 27, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.531% when pulling 3e0ea78 on lodash_version into ed884fb on master.

mikeproeng37
mikeproeng37 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

mikeproeng37 commented Jun 27, 2019 •
edited
Loading

@brandonhudavid As part of this PR, can you also include an entry into the changelog under the unreleased changes heading, explaining the fix and reference the issue #296 in it.

@mikeproeng37
Copy link
Contributor

Ship it!

@brandonhudavid brandonhudavid merged commit f1ce881 into master Jun 27, 2019
@brandonhudavid brandonhudavid deleted the lodash_version branch June 27, 2019 20:57
mikeproeng37 pushed a commit that referenced this pull request Aug 20, 2019
@brandonhudavid
Update lodash dependency to ^4.17.11 (#297)
26bf941 
* update lodash dependency to ^4.17.11

* update changelog
mikeproeng37 pushed a commit that referenced this pull request Aug 20, 2019
@brandonhudavid
Update lodash dependency to ^4.17.11 (#297)
3830d67 
* update lodash dependency to ^4.17.11

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mjc1283 mjc1283 Awaiting requested review from mjc1283

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two security vulnerabilities in lodash
3 participants
@brandonhudavid @coveralls @mikeproeng37