Skip to content

feat: Datafile management #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Apr 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
5fc68f3
feat (datafile management) [OASIS-4308]: Base implementation of HTTP …
mjc1283 Mar 15, 2019
1c80d37
feat (datafile manager): Abortable requests, abort on stop (#2)
mjc1283 Mar 19, 2019
8135a51
feat (datafile manager): Node datafile manager (#3)
mjc1283 Mar 19, 2019
2eec4e8
fix (datafile manager): Update datafile manager interface: onReady be…
mjc1283 Mar 19, 2019
8cbd16c
refactor (datafile manager): Update Headers type to only store at-mos…
mjc1283 Mar 21, 2019
c8650e3
feat (datafile manager)[OASIS-4310]: Browser datafile manager (#6)
mjc1283 Mar 22, 2019
cec5eee
feat (datafile manager): Increasing backoff delay after network error…
mjc1283 Mar 25, 2019
dcc0ed4
fix (datafile manager): Add several small fixes including top-level e…
mjc1283 Mar 26, 2019
82e4d0a
Merge branch 'master' into devel
Mar 26, 2019
5766c1a
feat(datafile manager): Update datafile manager interface to work wit…
mjc1283 Mar 27, 2019
36d5c55
(fix) Fix travis build (#10)
mjc1283 Mar 28, 2019
6a77bb2
Merge branch 'master' into devel
Mar 29, 2019
71954e7
Merge branch 'master' into devel
Mar 29, 2019
0ef64db
Add missing license headers. Move import statement under license header
Apr 1, 2019
d0b3b77
Add prepublishOnly script, and remove references to public SDK repo f…
Apr 1, 2019
4dcb5c4
fix (datafile manager): Change onReady meaning to 'a datafile is avai…
mjc1283 Apr 2, 2019
70c342a
feat (datafile management): Initialize datafile manager in Optimizely…
mjc1283 Apr 3, 2019
b53d102
Merge branch 'master' into devel
Apr 5, 2019
c987725
feat (datafile management): Implement automatic updates, datafile man…
mjc1283 Apr 8, 2019
c3b6ce7
fix (datafile manager): Small cleanups in datafile manager (#17)
mjc1283 Apr 8, 2019
3287c36
fix (datafile manager): Pass hostname and port in request options (#18)
mjc1283 Apr 9, 2019
8adfc7d
Fix README, remove unused enum
Apr 9, 2019
8db426d
fix (datafile management): Fix unhandled onReady promise rejections i…
mjc1283 Apr 9, 2019
29352c2
Merge branch 'master' into devel
Apr 9, 2019
b9c026f
Update CHANGELOG.md for v0.2.0
Apr 9, 2019
ec261d7
js-sdk-datafile-manager v0.2.0
Apr 9, 2019
e02c569
Update js-sdk-datafile-manager version to 0.2.0
Apr 9, 2019
309fc01
fix (project config manager): Only call update listener when datafile…
mjc1283 Apr 11, 2019
6c1b014
fix (project config manager): Fix onUpdate dispose function (#21)
mjc1283 Apr 11, 2019
b6884e9
Fix umd bundle tests
Apr 11, 2019
67105ba
fix (config update): Change notification name and log message to refe…
mjc1283 Apr 16, 2019
d95aee5
fix (project config manager & Optimizely): Always fulfill onReady Pro…
mjc1283 Apr 17, 2019
08f451f
Merge branch 'master' into devel
Apr 18, 2019
c4531e6
fix (forced variations): Move forced variation methods and state out …
mjc1283 Apr 18, 2019
de8546c
fix (onReady): Clear ready timeout when instance closed, and other sm…
mjc1283 Apr 19, 2019
0f55be2
ci(tests): Enable FSC tests to run on this repo. (#26)
mikeproeng37 Apr 23, 2019
bc34102
Merge branch 'master' into devel
Apr 23, 2019
3b4de0f
Remove TODO comment
Apr 23, 2019
ceedcd4
Update license headers on modified files (#27)
mjc1283 Apr 23, 2019
37134f9
Restore travis configuration from master
Apr 23, 2019
431ac49
Add datafile management entry in CHANGELOG.md
Apr 24, 2019
e268ba5
Fix code sample in CHANGELOG.md
Apr 24, 2019
cadfd66
Add config update notification to changelog entry
Apr 24, 2019
4a26bec
Use proper naming conventions in code samples
Apr 24, 2019
ae1c70a
Change node engines value in pacakge.json from >=4.0.0 to >=6.0.0
Apr 25, 2019
fc74699
Fix quotation marks in CHANGELOG.md code samples
Apr 25, 2019
8b0fdd9
Undo year update since the file was only moved, not changed
Apr 25, 2019
f40530f
Fix example import in datafile-manager README
Apr 25, 2019
2d33de8
Add change entry to CHANGELOG about forced variation log messages
Apr 26, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/datafile-manager/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lib
1 change: 1 addition & 0 deletions packages/datafile-manager/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v10
27 changes: 27 additions & 0 deletions packages/datafile-manager/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Changelog
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
Changes that have landed but are not yet released.

### Changed
- Changed value for node in engines in package.json from >=4.0.0 to >=6.0.0

## [0.2.0] - April 9, 2019

### Changed
- Increase max error count in backoff controller (can now delay requests for up to 512 seconds) [(#17)](https://github.com/optimizely/javascript-sdk-dev/pull/17)
- Change expected format of `urlTemplate` to be sprintf-compatible (`%s` is replaced with `sdkKey`) [(#17)](https://github.com/optimizely/javascript-sdk-dev/pull/17)
- Promise returned from `onReady` is resolved immediately when `datafile` provided in constructor [(#14)](https://github.com/optimizely/javascript-sdk-dev/pull/14)
- Emit update event whenever datafile changes, not only if `autoUpdate` is true [(#14)](https://github.com/optimizely/javascript-sdk-dev/pull/14)

### Fixed

- Fix for Node.js requests when `urlTemplate` contains a port [(#18)](https://github.com/optimizely/javascript-sdk-dev/pull/18)

## [0.1.0] - March 4, 2019

Initial release
202 changes: 202 additions & 0 deletions packages/datafile-manager/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@

Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2016-2017, Optimizely, Inc. and contributors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
31 changes: 31 additions & 0 deletions packages/datafile-manager/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Javascript SDK Datafile Manager

This package provides a datafile manager implementations for Node.js and the browser.

## Installation

```sh
npm install @optimizely/js-sdk-datafile-manager
```

## Usage

```js
const { DatafileManager } = require('@optimizely/js-sdk-datafile-manager')

const manager = new DatafileManager({
sdkKey: '9LCprAQyd1bs1BBXZ3nVji',
autoUpdate: true,
updateInterval: 5000,
})
manager.start()
manager.onReady().then(() => {
const datafile = manager.get()
console.log('Manager is ready with datafile: ')
console.log(datafile)
})
manager.on('update', ({ datafile }) => {
console.log('New datafile available: ')
console.log(datafile)
})
```
63 changes: 63 additions & 0 deletions packages/datafile-manager/__test__/backoffController.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/**
* Copyright 2019, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import BackoffController from '../src/backoffController'

describe('backoffController', () => {
describe('getDelay', () => {
it('returns 0 from getDelay if there have been no errors', () => {
const controller = new BackoffController()
expect(controller.getDelay()).toBe(0)
})

it('increases the delay returned from getDelay (up to a maximum value) after each call to countError', () => {
const controller = new BackoffController()
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(8000)
expect(controller.getDelay()).toBeLessThan(9000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(16000)
expect(controller.getDelay()).toBeLessThan(17000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(32000)
expect(controller.getDelay()).toBeLessThan(33000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(64000)
expect(controller.getDelay()).toBeLessThan(65000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(128000)
expect(controller.getDelay()).toBeLessThan(129000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(256000)
expect(controller.getDelay()).toBeLessThan(257000)
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(512000)
expect(controller.getDelay()).toBeLessThan(513000)
// Maximum reached - additional errors should not increase the delay further
controller.countError()
expect(controller.getDelay()).toBeGreaterThanOrEqual(512000)
expect(controller.getDelay()).toBeLessThan(513000)
})

it('resets the error count when reset is called', () => {
const controller = new BackoffController()
controller.countError()
expect(controller.getDelay()).toBeGreaterThan(0)
controller.reset()
expect(controller.getDelay()).toBe(0)
})
})
})
Loading