Marking activate listener as deprecated and preparing for 3.1.0 release #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aliabbasrizvi
commented
Apr 18, 2019
aliabbasrizvi
commented
- Marking activate listener as deprecated in favor of decision listener.
- Updating CHANGELOG for 3.1.0 release.
aliabbasrizvi
requested review from
jordangarcia,
mjc1283,
ceimaj and
mikeproeng37
mjc1283
reviewed
Apr 19, 2019
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| // valid levels: 'DEBUG', 'INFO', 'WARN', 'ERROR' | ||
| optimizelySDK.setLogLevel('WARN') | ||
| // enums can also be used | ||
| optimizelySDK.setLogLevel(optimizely.enums.LOG_LEVEL.ERROR) |
There was a problem hiding this comment.
Should say:
optimizelySDK.setLogLevel(optimizelySDK.enums.LOG_LEVEL.ERROR)
mjc1283
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.