Prepare 3.1.0-beta1 release #238
Conversation
packages/optimizely-sdk/CHANGELOG.MD
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - New APIs for setting `logger` and `logLevel` on the optimizelySDK singleton |
There was a problem hiding this comment.
Can we link to PRs for each change log item as we've done previously?
There was a problem hiding this comment.
Sure i think it's just one PR though
| - `logger` and `logLevel` are now set globally for all instances of Optimizely. If you were passing | ||
| different loggers to individual instances of Optimizely, logging behavior may now be different. | ||
|
|
||
| #### Setting a ConsoleLogger |
There was a problem hiding this comment.
Do you think we should stick with the standard sections of Changed, New Features, Breaking Changes, or is it OK to introduce these examples here? If we had a link to the logging package README, it might solve the same need while keeping the changelog format the same.
There was a problem hiding this comment.
the logging package isn't great for external documentation because it's the internal interfaces, not what we expose through the SDK.
There was a problem hiding this comment.
Also i personally like the examples. I think it's the best way to convey the idea to a lot of people.
Summary
loggerandlogLevelon the optimizelySDK singletonloggerandlogLevelare now set globally for all instances of Optimizely. If you were passingdifferent loggers to individual instances of Optimizely, logging behavior may now be different.
Test plan
Issues