(chore): Prepare for 3.0.0 release #217
Conversation
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| @@ -7,61 +7,48 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ## [Unreleased] | |||
| Changes that have landed but are not yet released. | |||
|
|
|||
| ## [3.0.0-rc2] - November 16, 2018 | |||
| ## 3.0.0 - February 13, 2019 | |||
There was a problem hiding this comment.
Perhaps [3.0.0] for consistency sake?
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| - Drops `window.optimizelyClient` from the bundled build. | ||
|
|
||
| ### Bug Fixes: | ||
| - Experiments and features can no longer activate when a negatively targeted attribute has a missing, null, or malformed value. |
There was a problem hiding this comment.
Shouldn't we have links to PRs as we were doing previously?
There was a problem hiding this comment.
We dropped them because it's difficult to attribute some of these items to a single PR. I suppose we could link to any PR that contributed to an item, but I'm not sure how useful that would be. @nchilada thoughts?
There was a problem hiding this comment.
I think we were some inconsistent on this front... I did omit PR links in the centralized draft of the release notes, primarily for logistical reasons, but also because some changes couldn't be described by a single PR.
I'd say SDK releasers are free to add links, but they're not easy to determine for all changes, and I personally am not gonna require them.
There was a problem hiding this comment.
👍 I'll add links to relevant PRs for top-level items.
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| - Drops `window.optimizelyClient` from the bundled build. | ||
|
|
||
| ### Bug Fixes: | ||
| - Experiments and features can no longer activate when a negatively targeted attribute has a missing, null, or malformed value. |
There was a problem hiding this comment.
I think we were some inconsistent on this front... I did omit PR links in the centralized draft of the release notes, primarily for logistical reasons, but also because some changes couldn't be described by a single PR.
I'd say SDK releasers are free to add links, but they're not easy to determine for all changes, and I personally am not gonna require them.
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| ### Breaking Changes: | ||
|
|
||
| - Previously, notification listeners were only given string-valued user attributes because only strings could be passed into various method calls. That is no longer the case. You may pass non-string attribute values, and if you do, you must update your notification listeners to be able to receive whatever values you pass in ([#174](https://github.com/optimizely/javascript-sdk/pull/174), [#204](https://github.com/optimizely/javascript-sdk/pull/204)). | ||
| - Drops `window.optimizelyClient` from the bundled build ([#189](https://github.com/optimizely/javascript-sdk/pull/189)). |
There was a problem hiding this comment.
Nit, for convenience, can we say that you should use window.optimizelySdk instead?
There was a problem hiding this comment.
Ooh yeah, that'd make sense. I had no idea!
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| ### Breaking Changes: | ||
|
|
||
| - Previously, notification listeners were only given string-valued user attributes because only strings could be passed into various method calls. That is no longer the case. You may pass non-string attribute values, and if you do, you must update your notification listeners to be able to receive whatever values you pass in ([#174](https://github.com/optimizely/javascript-sdk/pull/174), [#204](https://github.com/optimizely/javascript-sdk/pull/204)). | ||
| - Drops `window.optimizelyClient` from the bundled build ([#189](https://github.com/optimizely/javascript-sdk/pull/189)). |
There was a problem hiding this comment.
Ooh yeah, that'd make sense. I had no idea!
Summary
Prepare for 3.0.0 release.