Skip to content

refactor(dist): update bundled files #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
Changes that have landed but are not yet released.

### Breaking Changes

Drops `window.optimizelyClient` from the bundled build ([#189](https://github.com/optimizely/javascript-sdk/pull/189)).

### Fixes
- fix(bundling): Publish the unminified UMD bundle along with the minified one. ([#187](https://github.com/optimizely/javascript-sdk/pull/187))

## [3.0.0-rc] - November 6, 2018

This is the release candidate version of the 3.0 SDK:
Expand Down
5 changes: 4 additions & 1 deletion packages/optimizely-sdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ See the Optimizely X Full Stack [developer documentation](http://developers.opti
The package's entry point is a CommonJS module, which can be used directly in environments which support it (e.g., Node.js, or loaded in a browser via Browserify or RequireJS). Additionally, you can include a standalone bundle of the SDK in your web page by fetching it from [unpkg](https://unpkg.com/):

```html
<script src="https://unpkg.com/@optimizely/optimizely-sdk/dist/optimizely.browser.umd.min.js"></script>

<!-- You can also use the unminified version if necessary -->
<script src="https://unpkg.com/@optimizely/optimizely-sdk/dist/optimizely.browser.umd.js"></script>
```

Expand Down Expand Up @@ -120,4 +123,4 @@ To regenerate this, run the following command:
npx license-checker --production --json | jq 'map_values({ licenses, publisher, repository }) | del(.[][] | nulls)'
```

and remove the self (`@optimizely/optimizely-sdk`) entry.
and remove the self (`@optimizely/optimizely-sdk`) entry.
34 changes: 19 additions & 15 deletions packages/optimizely-sdk/karma.bs.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,21 @@ module.exports = function(config) {
//plugins
plugins: ['karma-mocha', 'karma-webpack', require('karma-browserstack-launcher')],

webpack: {
mode: 'production',
},

//browserStack setup
browserStack: {
username: process.env.BROWSER_STACK_USERNAME,
accessKey: process.env.BROWSER_STACK_ACCESS_KEY
},

// to avoid DISCONNECTED messages when connecting to BrowserStack
browserDisconnectTimeout : 10000, // default 2000
browserDisconnectTolerance : 1, // default 0
browserNoActivityTimeout : 4*60*1000, //default 10000
captureTimeout : 4*60*1000, //default 60000
browserDisconnectTimeout: 10000, // default 2000
browserDisconnectTolerance: 1, // default 0
browserNoActivityTimeout: 4 * 60 * 1000, //default 10000
captureTimeout: 4 * 60 * 1000, //default 60000

// define browsers
customLaunchers: {
Expand All @@ -37,7 +41,7 @@ module.exports = function(config) {
os_version: '10',
browser: 'edge',
device: null,
browser_version: "15.0"
browser_version: '15.0'
},
bs_firefox_mac: {
base: 'BrowserStack',
Expand All @@ -48,11 +52,11 @@ module.exports = function(config) {
},
bs_ie: {
base: 'BrowserStack',
os: "Windows",
os_version: "7",
browser: "ie",
os: 'Windows',
os_version: '7',
browser: 'ie',
device: null,
browser_version: "10.0"
browser_version: '10.0'
},
bs_iphone6: {
base: 'BrowserStack',
Expand All @@ -69,11 +73,11 @@ module.exports = function(config) {
},
bs_safari: {
base: 'BrowserStack',
os: "OS X",
os_version: "Mountain Lion",
browser: "safari",
os: 'OS X',
os_version: 'Mountain Lion',
browser: 'safari',
device: null,
browser_version: "6.2"
browser_version: '6.2'
}
},

Expand Down Expand Up @@ -131,5 +135,5 @@ module.exports = function(config) {
// Concurrency level
// how many browser should be started simultaneous
concurrency: Infinity
})
}
});
};
Loading