fix (audiences): Update project config - no longer expect conditions of audiences in typedAudiences to be strings #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchilada
approved these changes
Nov 1, 2018
| /* | ||
| * Note: conditions of audiences in projectConfig.typedAudiences are not | ||
| * expected to be string-encoded as they are in projectConfig.audiences. | ||
| */ |
There was a problem hiding this comment.
Can you move this comment three lines up and maybe adapt it as necessary? I'm kinda trained to assume each code comments applies to the statement that follows it, which is not the case here.
I guess something like
fns.forEach(projectConfig.typedAudiences, function(audience) {
// Comment here
});would also work but that's weird and might be inefficient. 😕
added 2 commits
November 6, 2018 14:38
…in typedAudiences are strings.
mjc1283
force-pushed
the
mcarroll/typed-audiences-conditions-not-strings
branch
from
5699263 to
c633fd3
Compare
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update project config to handle the latest datafile format for 3.0 with typed audience evaluation.
conditionsproperties of objects intypedAudienceswill beArrays, and no longer JSON-Strings.Test Plan
Updated typed audiences datafile in test data to the latest format. Existing tests should pass - no change in behavior.