feat (audiences): Typed audience evaluation #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce match types (#171) Summary: This adds support for new audience match type conditions to the condition evaluator: - exact, exists, gt, lt, and substring conditions - Abort and return null when appropriate in leaf evaluators - Null handling in and/or/not evaluators - Assume implicit "or" when operator is missing Test Plan: Added new unit tests. Ran compatibility suite tests.
…nfig for new audience match types (#173) This updates project config and the audience evaluator to finish the implementation of typed audience evaluation: - In audience_evaluator, allow evaluation to continue when no user attributes are passed (previously we were immediately returning `false` when no attributes were passed) - Update project_config: in `createProjectConfig`, set up a by-id object for accessing audiences from both `audiences` and `typedAudiences`. Also, update `getAudiencesForExperiment` to first look in `projectConfig.typedAudiences`, and only look in `projectConfig.audiences` as a fallback. - Added unit tests checking that all top-level methods that accept user attributes can bucket users into experiments or rollouts that use typed audiences.
1 similar comment
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for typed audience evaluation. Includes changes from #171 and #173.